cjolivier01 commented on a change in pull request #9464: refactor logging in infer storage pass URL: https://github.com/apache/incubator-mxnet/pull/9464#discussion_r162442133
########## File path: src/common/utils.h ########## @@ -426,13 +428,13 @@ inline void LogStorageFallback(const nnvm::NodeAttrs& attrs, if (!log) return; const std::string op_str = operator_stype_string(attrs, dev_mask, *in_attrs, *out_attrs); std::ostringstream os; - os << "\nStorage type fallback detected:\n" << op_str - << "\nThe operator with default storage type will be dispatched for execution. " - << "You're seeing this warning message because the operator above is unable to " - << "process the given ndarrays with specified storage types, context and parameter. " - << "Temporary dense ndarrays are generated in order to execute the operator. " - << "You can set environment variable " - << "MXNET_STORAGE_FALLBACK_LOG_VERBOSE to 0 to suppress this warning."; + const std::string warning = "\nThe operator with default storage type will be dispatched " Review comment: nit: This could probably be "const char *" and then std::string wouldn;t have to allocate memory and copy the string into it every pass :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
