cjolivier01 commented on a change in pull request #9464: refactor logging in
infer storage pass
URL: https://github.com/apache/incubator-mxnet/pull/9464#discussion_r162443617
##########
File path: src/operator/operator_common.h
##########
@@ -350,11 +350,12 @@ inline bool storage_type_assign(StorageTypeVector*
stypes,
/*! \brief update the stype vector to default storage and dispatch_mode to
fallback
*/
-inline void dispatch_fallback(StorageTypeVector* stypes, DispatchMode*
dispatch) {
+inline bool dispatch_fallback(StorageTypeVector* stypes, DispatchMode*
dispatch) {
Review comment:
nit: why lowercase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
