anirudh2290 commented on a change in pull request #9681: Better Exception
Handling for Operators
URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165792490
##########
File path: src/engine/threaded_engine.cc
##########
@@ -391,6 +400,11 @@ void ThreadedEngine::WaitForAll() {
finished_cv_.wait(lock, [this]() {
return pending_.load() == 0 || kill_.load();
});
+ if (global_ex_ptr) {
+ std::exception_ptr ex_ptr = global_ex_ptr;
Review comment:
Rolling this back, Since the state of global_ex_ptr is not guaranteed to be
nullptr after the move and it depends on the implementation. This probably
explains why it started failing on windows, after the change. Please let me
know if you have any concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
