TaoLv commented on a change in pull request #9918: Update mkldnn to the newest
& Add clang build test with mkldnn.
URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r171865575
##########
File path: src/operator/nn/mkldnn/mkldnn_base.cc
##########
@@ -237,13 +237,14 @@ mkldnn_memory_format_t
GetDefaultFormat(mkldnn::memory::desc desc) {
case mkldnn_gOIhw16o16i:
case mkldnn_gIOhw16o16i:
case mkldnn_gOihw8o:
+ case mkldnn_Goihw8g:
case mkldnn_gOihw16o:
case mkldnn_gOhwi8o:
case mkldnn_gOhwi16o:
case mkldnn_gOhIw16o4i:
return mkldnn_goihw;
default:
- LOG(FATAL) << "Unknown MKLDNN format for 4 dimensions: " <<
desc.data.format;
+ LOG(FATAL) << "Unknown MKLDNN format for 5 dimensions: " <<
desc.data.format;
Review comment:
Because all the 5D data formats that mkldnn supported currently are covered
by the swich-case statement here. So I don't think we can create a
`mkldnn::memory::desc` with another 5D data format to touch the default
statement.
One feasible method is to set a test case to check whether there is a new
format added into mkldnn data format list. If the test case is failed, maybe we
need check the code here and add the new format into the switch-case statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
