eric-haibin-lin commented on a change in pull request #10150: [WIP] [DO NOT
MERGE] Sparse operator broadcast_mul/div(csr, dense) = csr
URL: https://github.com/apache/incubator-mxnet/pull/10150#discussion_r175536238
##########
File path: src/operator/tensor/elemwise_binary_broadcast_op.h
##########
@@ -76,6 +77,31 @@ inline bool BinaryBroadcastShape(const nnvm::NodeAttrs&
attrs,
return true;
}
+inline bool BinaryBroadcastStorageTypeCsr(const nnvm::NodeAttrs& attrs,
+ const int dev_mask,
+ DispatchMode* dispatch_mode,
+ std::vector<int>* in_attrs,
+ std::vector<int>* out_attrs) {
+ CHECK_EQ(in_attrs->size(), 2U);
+ CHECK_EQ(out_attrs->size(), 1U);
+ const int in1_stype = in_attrs->at(0);
Review comment:
I'd think left/right-hand side (`lhs`/`rhs`) is a better name compared to
`in1`/`in2`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
