eric-haibin-lin commented on a change in pull request #10150: [WIP] [DO NOT 
MERGE] Sparse operator broadcast_mul/div(csr, dense) = csr
URL: https://github.com/apache/incubator-mxnet/pull/10150#discussion_r175535765
 
 

 ##########
 File path: src/operator/tensor/elemwise_binary_broadcast_op.h
 ##########
 @@ -76,6 +77,31 @@ inline bool BinaryBroadcastShape(const nnvm::NodeAttrs& 
attrs,
   return true;
 }
 
+inline bool BinaryBroadcastStorageTypeCsr(const nnvm::NodeAttrs& attrs,
 
 Review comment:
   No need to put Csr in the title since we may add row_sparse in the same 
function in future. Also the name is confusing because this is only for mul/div

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to