eric-haibin-lin commented on a change in pull request #10374: Sparse support
for Custom Op
URL: https://github.com/apache/incubator-mxnet/pull/10374#discussion_r178687355
##########
File path: src/operator/custom/custom-inl.h
##########
@@ -64,31 +64,59 @@ class CustomOperator {
return nullptr;
}
- template<typename Func>
- void Push(const Func& func,
- const OpContext& ctx,
- bool recording,
- bool training,
- const std::vector<NDArray>& arrs) {
+ template <typename Func>
+ void Push(const Func& func, const OpContext& ctx, bool recording,
Review comment:
Add some doc explaining why we need to pass inputs/outputs array?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
