eric-haibin-lin commented on a change in pull request #10374: Sparse support for Custom Op URL: https://github.com/apache/incubator-mxnet/pull/10374#discussion_r178687478
########## File path: tests/python/unittest/test_operator.py ########## @@ -4059,6 +4059,79 @@ def create_operator(self, ctx, shapes, dtypes): with mx.contrib.autograd.train_section(): y = mx.nd.Custom(x, aux, op_type='sqr') y.backward() + y.wait_to_read() + x.grad.wait_to_read() + + # test for backward compatibility, i.e. the correctness of default implementation of + # infer storage in custom operator + class Mult(mx.operator.CustomOp): + def forward(self, is_train, req, in_data, out_data, aux): Review comment: nit: 8 space indentation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services