zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r183134591
########## File path: src/operator/quantization/mkldnn/mkldnn_dequantize-inl.h ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file mkldnn_quantized_conv-inl.h + * \author Wenting Jiang + * \brief + */ + +#ifndef MXNET_OPERATOR_QUANTIZATION_MKLDNN_MKLDNN_DEQUANTIZE_INL_H_ +#define MXNET_OPERATOR_QUANTIZATION_MKLDNN_MKLDNN_DEQUANTIZE_INL_H_ +#if MXNET_USE_MKLDNN == 1 +#include <string> +#include <algorithm> +#include <vector> +#include "../../nn/mkldnn/mkldnn_base-inl.h" + +namespace mxnet { +namespace op { + +template<typename SrcType, typename DstType> +void MKLDNNDequantizeComputeKer(const std::vector<NDArray> &inputs, + const std::vector<NDArray> &outputs, + const std::vector<OpReqType> &req) { + using namespace mshadow; + using namespace mxnet_op; + using red::limits::MaxValue; + using red::limits::MinValue; + float real_range = 0.0; + float quantized_range = 0.0; + if (inputs[0].dtype() == mshadow::kUint8) { + quantized_range = MaxAbs(MaxValue<SrcType>(), MinValue<SrcType>()); + real_range = MaxAbs(*inputs[1].data().dptr<DstType>(), *inputs[2].data().dptr<DstType>()); + } else if (inputs[0].dtype() == mshadow::kInt8) { + quantized_range = MinAbs(MaxValue<SrcType>(), MinValue<SrcType>()); + real_range = MaxAbs(*inputs[1].data().dptr<DstType>(), *inputs[2].data().dptr<DstType>()); Review comment: why do we need if ... else ... here? everything in the "if" block is the same as the "else if" block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
