marcoabreu commented on a change in pull request #10629: [MXNET-343]fix Mkldnn with msvc URL: https://github.com/apache/incubator-mxnet/pull/10629#discussion_r183215160
########## File path: CMakeLists.txt ########## @@ -18,8 +18,8 @@ mxnet_option(USE_CUDNN "Build with cudnn support" ON) # one could se mxnet_option(USE_SSE "Build with x86 SSE instruction support" ON) mxnet_option(USE_LAPACK "Build with lapack support" ON IF NOT MSVC) mxnet_option(USE_MKL_IF_AVAILABLE "Use MKL if found" ON) -mxnet_option(USE_MKLML_MKL "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND UNIX AND (NOT APPLE)) -mxnet_option(USE_MKLDNN "Use MKLDNN variant of MKL (if MKL found)" ON IF USE_MKL_IF_AVAILABLE AND UNIX AND (NOT APPLE)) +mxnet_option(USE_MKLML_MKL "Use MKLDNN variant of MKL (if MKL found)" OFF IF (NOT APPLE)) Review comment: Please keep the USE_MKL_IF_AVAILABLE argument - you're changing the default behaviour here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
