marcoabreu commented on a change in pull request #10629: [MXNET-343]fix Mkldnn
with msvc
URL: https://github.com/apache/incubator-mxnet/pull/10629#discussion_r183215285
##########
File path: python/mxnet/libinfo.py
##########
@@ -37,6 +38,8 @@ def find_lib_path():
logging.warning("MXNET_LIBRARY_PATH should be an absolute
path, instead of: %s",
lib_from_env)
else:
+ if os.name == 'nt':
+ os.environ['PATH'] = os.path.dirname(lib_from_env) + ';' +
os.environ['PATH']
Review comment:
Please append to the end of path instead of the beginning to prevent path
masking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
