marcoabreu commented on a change in pull request #10760: [MXNET-372] Add build 
flag for USE_F16C in CMake and clarify flag in make
URL: https://github.com/apache/incubator-mxnet/pull/10760#discussion_r185155046
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -102,6 +104,29 @@ else(MSVC)
   else()
     set(SUPPORT_MSSE2 FALSE)
   endif()
+  # For cross complication, turn off flag if target device does not support it
+  if(USE_F16C AND NOT MSVC)
 
 Review comment:
   It is already guaranteed that MSVC is not present at this point

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to