marcoabreu commented on a change in pull request #10760: [MXNET-372] Add build flag for USE_F16C in CMake and clarify flag in make URL: https://github.com/apache/incubator-mxnet/pull/10760#discussion_r185156992
########## File path: CMakeLists.txt ########## @@ -86,6 +87,8 @@ if(MSVC) add_definitions(-DNNVM_EXPORTS) add_definitions(-DDMLC_STRICT_CXX11) add_definitions(-DNOMINMAX) + set(SUPPORT_F16C FALSE) Review comment: This question might be stupid, but why are we disabling support on Windows? If this is a processor instruction, why does it depend on the OS? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
