piiswrong commented on a change in pull request #10311: [MXNET-107]Fused GRU implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10311#discussion_r189697573
########## File path: src/operator/rnn_impl.h ########## @@ -40,6 +40,9 @@ #include "./mshadow_op.h" #include "./linalg.h" +#define UNIDIRECT 1 Review comment: Use named enum instead of define ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
