piiswrong commented on a change in pull request #10311: [MXNET-107]Fused GRU
implementation for CPU
URL: https://github.com/apache/incubator-mxnet/pull/10311#discussion_r192891662
##########
File path: src/operator/rnn-inl.h
##########
@@ -474,6 +495,9 @@ class RNNOp : public Operator{
CHECK(dw.CheckContiguous());
CHECK(dhx.CheckContiguous());
CHECK(dy.CheckContiguous());
+ if (req[rnn_enum::kParams] != kAddTo && req[rnn_enum::kParams] != kNullOp)
{
Review comment:
Isn't gradient still going to be overwritten by backward kernel later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
