haojin2 commented on a change in pull request #11229: [MXNET-379] L1
Normalization
URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r194528251
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -999,13 +1003,18 @@ void L2NormCompute(const nnvm::NodeAttrs& attrs,
} else {
small = ReduceAxesShapeImpl(inputs[0].shape_, param.axis, true, false);
}
- ReduceAxesComputeImpl<xpu, mshadow::red::sum, false, mshadow_op::square>(
- ctx, inputs, req, outputs, small);
- SqRootForL2<xpu>(ctx, req[0], outputs[0]);
+ if (param.ord == 1) {
+ ReduceAxesComputeImpl<xpu, mshadow::red::sum, false, mshadow_op::abs>(
+ ctx, inputs, req, outputs, small);
+ } else if (param.ord == 2) {
+ ReduceAxesComputeImpl<xpu, mshadow::red::sum, false, mshadow_op::square>(
+ ctx, inputs, req, outputs, small);
+ SqRootForL2<xpu>(ctx, req[0], outputs[0]);
+ }
Review comment:
Better add an extra else branch with a warning message if the ord exceeds
what we support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
