haojin2 commented on a change in pull request #11229: [MXNET-379] L1
Normalization
URL: https://github.com/apache/incubator-mxnet/pull/11229#discussion_r199025529
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1021,8 +1023,38 @@ void L2NormGradCompute(const nnvm::NodeAttrs& attrs,
} else {
small = ReduceAxesShapeImpl(outputs[0].shape_, param.axis, true, false);
}
- ReduceAxesBackwardUseInOutImpl<xpu, mshadow_op::div, false>(ctx, small,
inputs,
+ if (param.ord == 1) {
+ using namespace mshadow;
+ using namespace mshadow::expr;
Review comment:
These to `using namespace` line are redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
