anirudhacharya commented on a change in pull request #11213: [MXNET-533] MXNet-ONNX export URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r194879799
########## File path: python/mxnet/contrib/onnx/__init__.py ########## @@ -18,3 +18,4 @@ from ._import.import_model import import_model, get_model_metadata Review comment: ``import`` is a reserved keyword, we cant have a folder called import. we can probably rename the two folders to onnx_import and onnx_export and make its member files private, except for the modules that we are exposing to the user. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
