anirudhacharya commented on a change in pull request #11213: [MXNET-533] 
MXNet-ONNX export
URL: https://github.com/apache/incubator-mxnet/pull/11213#discussion_r198989213
 
 

 ##########
 File path: tests/python-pytest/onnx/export/backend.py
 ##########
 @@ -0,0 +1,98 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   in the future if there is another component that is built into MXNet that 
uses pytest instead of nosetests, then what will we do?
   
   the point of naming it python-pytest is separate them from the other tests 
which uses nosetests framework? 
   
   And this naming was part of a previous PR 
https://github.com/apache/incubator-mxnet/pull/9963 and was suggested by 
@marcoabreu during the review process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to