zheng-da commented on a change in pull request #11301: MKLDNN Backward op cache
URL: https://github.com/apache/incubator-mxnet/pull/11301#discussion_r200819508
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -283,6 +283,157 @@ void MKLDNNConvolutionForward(const nnvm::NodeAttrs&
attrs, const OpContext &ctx
MKLDNNStream::Get()->Submit();
}
+class MKLDNNConvBackward {
+ std::shared_ptr<mkldnn::convolution_backward_data> bwd_data;
+ std::shared_ptr<mkldnn::convolution_backward_weights> bwd_weight;
+ // conv::kData
+ std::shared_ptr<mkldnn::memory> out_grad;
+ std::shared_ptr<mkldnn::memory> in_grad;
+ std::shared_ptr<mkldnn::memory> weight;
+ // conv::kWeight
+ std::shared_ptr<mkldnn::memory> data;
+ std::shared_ptr<mkldnn::memory> output;
+ std::shared_ptr<mkldnn::memory> in_grad_weight;
+ std::shared_ptr<mkldnn::memory> in_grad_bias;
+
+ public:
+ mkldnn::convolution_backward_data::primitive_desc bwdData_pd;
+ mkldnn::convolution_backward_weights::primitive_desc bwdWeights_pd;
+
+ MKLDNNConvBackward(
+ const ConvolutionParam ¶m, const NDArray &data,
+ const NDArray &weights, const NDArray *bias, const NDArray &output,
+ const mkldnn::convolution_forward::primitive_desc &fwd_pd):
+ bwdData_pd(GetConvBwdData(param, data, weights, output, fwd_pd)),
+ bwdWeights_pd(GetConvBwdWeights(param, data, weights, bias, output,
fwd_pd)) {
+ }
+
+ void SetDataNewMem(const mkldnn::memory &out_grad, const mkldnn::memory
&weight,
+ const mkldnn::memory &in_grad) {
+ if (this->out_grad == nullptr)
+ this->out_grad = std::shared_ptr<mkldnn::memory>(new mkldnn::memory(
+ bwdData_pd.diff_dst_primitive_desc(), out_grad.get_data_handle()));
+ else
+ this->out_grad->set_data_handle(out_grad.get_data_handle());
+ if (this->in_grad == nullptr)
+ this->in_grad = std::shared_ptr<mkldnn::memory>(new mkldnn::memory(
+ bwdData_pd.diff_src_primitive_desc(), in_grad.get_data_handle()));
+ else
+ this->in_grad->set_data_handle(in_grad.get_data_handle());
+ if (this->weight == nullptr)
+ this->weight = std::shared_ptr<mkldnn::memory>(new mkldnn::memory(
+ bwdData_pd.weights_primitive_desc(), weight.get_data_handle()));
+ else
+ this->weight->set_data_handle(weight.get_data_handle());
+ if (this->bwd_data == nullptr)
+ this->bwd_data = std::shared_ptr<mkldnn::convolution_backward_data>(
+ new mkldnn::convolution_backward_data(
+ this->bwdData_pd, mkldnn::primitive::at(*this->out_grad),
+ mkldnn::primitive::at(*this->weight), *this->in_grad));
+ }
+
+void SetWeightNewMem(const mkldnn::memory &data,
+ const mkldnn::memory &out_grad,
+ const mkldnn::memory &in_grad_weight) {
Review comment:
indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
