zheng-da commented on a change in pull request #11301: MKLDNN Backward op cache
URL: https://github.com/apache/incubator-mxnet/pull/11301#discussion_r200819757
##########
File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc
##########
@@ -82,6 +82,101 @@ inline static
mkldnn::inner_product_backward_weights::primitive_desc GetIPBwdWei
}
}
+class MKLDNNFullyConnectForward {
Review comment:
could you take the caching of FullyConnected forward out and submit another
PR for this?
my concern is that this PR is for caching backward. mixing it with all other
backward operators might cause confusing later. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
