marcoabreu commented on a change in pull request #11630: [WIP] Fix flaky test 
test_deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/11630#discussion_r201789608
 
 

 ##########
 File path: tests/python/unittest/common.py
 ##########
 @@ -94,6 +95,23 @@ def random_seed(seed=None):
         random.seed(next_seed)
 
 
+def assert_raises_cudnn_disabled(assertion_error=False):
+    def test_helper(orig_test):
+        @make_decorator(orig_test)
+        def test_new(*args, **kwargs):
+            cudnn_disabled = (os.getenv('CUDNN_DISABLED') == "ON")
+            if not cudnn_disabled or mx.context.current_context().device_type 
== 'cpu':
+                orig_test(*args, **kwargs)
+            else:
+                if assertion_error:
 
 Review comment:
   I see, thanks for elaborating. It seems to be like that you revealed a bug 
in our backend about the handling of the missing cudnn.
   
   I don't think this is what should happen. If a user uses an operator 
although it's not supported, it should not make a false calculation but rather 
throw the error properly. This method would mask a problem that a user would 
silently encounter. We should rather investigate why the error is not being 
thrown and fix that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to