marcoabreu commented on a change in pull request #11630: [WIP] Fix flaky test
test_deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/11630#discussion_r201821605
##########
File path: Jenkinsfile
##########
@@ -667,6 +680,21 @@ try {
}
}
},
+ 'Python3: MKLDNN-GPU-NOCUDNN': {
+ node('mxnetlinux-gpu') {
+ ws('workspace/ut-python3-mkldnn-gpu-nocudnn') {
+ withEnv(['CUDNN_DISABLED=ON']) {
Review comment:
I don't know if this is cleaner because that way you are catching all errors
independently of whether they are actually related to cudnn. Imagine somebody
makes a change to the cudnn behaviour but there is is still a bug - the error
gets then omitted and we don't notice it. I'd rather have detailed and specific
error handling rather than a global try-catch. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
