azai91 commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool
test
URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202098519
##########
File path: tests/cpp/operator/mkldnn.cc
##########
@@ -515,33 +557,34 @@ void PrintVerifyMsg(const NDArrayAttrs &arr1, const
NDArrayAttrs &arr2) {
*
* num_inputs / dim arguments used to scale shape (used for concat backwards
to enlarge input shapes)
*/
-std::vector<NDArrayAttrs> GetTestInputArrays(bool rand = false, int num_inputs
= 1, int dim = 0) {
+std::vector<NDArrayAttrs> GetTestInputArrays(bool rand = false,
+ std::vector<float> scale = {1}) {
Review comment:
actually I can revert this. I did this cause I was expecting to modify the
input shape for pooling backwards. ended up taking a different approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
