azai91 commented on a change in pull request #11608: [MXNET-489] MKLDNN Pool
test
URL: https://github.com/apache/incubator-mxnet/pull/11608#discussion_r202817376
##########
File path: src/operator/nn/mkldnn/mkldnn_pooling.cc
##########
@@ -255,7 +252,10 @@ void MKLDNNPoolingCompute(const OpContext &ctx, const
PoolingParam ¶m,
const NDArray &in_data, const OpReqType req,
const NDArray &out_data, const NDArray *workspace) {
auto fwd = GetPoolingFwd(param, ctx.is_train, in_data, out_data);
- fwd.SetDataHandle(in_data, out_data, workspace);
+ auto input_mem = in_data.GetMKLDNNData();
+ auto out_mem_t = CreateMKLDNNMem(out_data,
fwd.fwd_pd_->dst_primitive_desc(), req, &in_data);
Review comment:
do you mean we should remove the CreateMKLDNNMem / CommitOutput here as we
don't need to worry about writing inplace?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
