lupesko commented on a change in pull request #11780: fix flaky test
test_operator_gpu.test_countsketch
URL: https://github.com/apache/incubator-mxnet/pull/11780#discussion_r203254580
##########
File path: src/operator/contrib/count_sketch.cu
##########
@@ -165,7 +165,8 @@ inline void CountSketchBackward(const Tensor<gpu, 2,
DType> &in_grad,
nthreads, in_grad_ptr+bstart*in_dim, h_ptr,
s_ptr, out_grad_ptr+bstart*out_dim, batchlen,
in_dim, out_dim);
- MSHADOW_CUDA_POST_KERNEL_CHECK(sketch_backward_kernel);
+ cudaError_t err = cudaDeviceSynchronize();
Review comment:
DRY - this check repeats in line 132 (and maybe elsewhere?) - did you
consider refactoring into a common function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
