toddsundsted commented on a change in pull request #11397: Avoid Division by
Zero
URL: https://github.com/apache/incubator-mxnet/pull/11397#discussion_r205060841
##########
File path: src/operator/random/sampler.h
##########
@@ -38,12 +38,17 @@ namespace op {
* \brief Launch a generic kernel with parallel random generator.
* \tparam gen random generator
* \tparam N Number of iterations
- * \tparam Args Varargs type to eventually pass to the OP::Map() functoion
+ * \tparam Args Varargs type to eventually pass to the OP::Map() function
*/
template<typename OP, typename xpu, typename GType, typename ...Args>
inline static void LaunchRNG(mshadow::Stream<xpu> *s,
common::random::RandGenerator<xpu, GType> *gen,
const int N, Args... args) {
+ // minimal check to avoid division by zero, below.
+ // if `N` is zero the map operation is a no-op in any case.
+ if (N == 0) {
Review comment:
@zhreshold fixed in 6075fc26. cleaned up commit history with rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
