marcoabreu commented on a change in pull request #11874: [MXNET-711] Fixing the
version build to show 1.2.1 instead of 1.2.0
URL: https://github.com/apache/incubator-mxnet/pull/11874#discussion_r205073632
##########
File path: docs/build_version_doc/AddVersion.py
##########
@@ -36,7 +36,7 @@
tag_list = list()
with open('tag_list.txt', 'r') as tag_file:
for line in tag_file:
- tag_list.append(line.lstrip().rstrip())
+
tag_list.append(line.lstrip().rstrip().replace("0.12.0","0.12.1").replace("1.2.0","1.2.1"))
Review comment:
I think we should rather have some generalized logic aka select each major
and minor version and the highest patch. This replace doesn't look right to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
