marcoabreu commented on a change in pull request #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#discussion_r205390143
########## File path: ci/docker/runtime_functions.sh ########## @@ -895,6 +895,25 @@ nightly_test_javascript() { make -C /work/mxnet/amalgamation libmxnet_predict.js MIN=1 EMCC=/work/deps/emscripten/emcc } +#Tests Model backwards compatibility on MXNet +nightly_model_backwards_compat_test() { + set -ex + export PYTHONPATH=./python/ + ./tests/nightly/model_backwards_compatibility_check/model_backward_compat_checker.sh +} + +#Backfills S3 bucket with models trained on earlier versions of mxnet +nightly_model_backwards_compat_train() { + set -ex + export PYTHONPATH=./python/ + VENV=mbcc_py2_venv + virtualenv -p `which python2` $VENV Review comment: If you run inside a virtualenv, you won't have access to any installed packages. I'd recommend not to use virtualenv here because you're running inside docker anyways. This is also the reason for the CI error that states it could not find boto3. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services