marcoabreu commented on a change in pull request #11626: [MXNET-651] MXNet
Model Backwards Compatibility Checker
URL: https://github.com/apache/incubator-mxnet/pull/11626#discussion_r206247590
##########
File path:
tests/nightly/model_backwards_compatibility_check/train_mxnet_legacy_models.sh
##########
@@ -57,10 +57,10 @@ do
fi
## If MXNet major version starts with a number >=1. with a wildcard
match for the minor version numbers
- if [[ $version = [1-9]* ]]
+ if [[ $version = [1-9].[0-9].[0-9] ]]
Review comment:
I don't think this will handle multi digit versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
