szha commented on a change in pull request #11928: Generalized reshape_like
operator
URL: https://github.com/apache/incubator-mxnet/pull/11928#discussion_r206018627
##########
File path: src/operator/tensor/elemwise_unary_op_basic.cc
##########
@@ -350,10 +350,108 @@ NNVM_REGISTER_OP(_identity_with_attr_like_rhs)
.add_argument("lhs", "NDArray-or-Symbol", "First input.")
.add_argument("rhs", "NDArray-or-Symbol", "Second input.");
+void ReshapeLikeRangeCanonicalize(int ndims, const char *side, int begin,
+ const dmlc::optional<int> &end, int *cbegin,
+ int *cend) {
+ *cbegin = begin;
+ if (*cbegin < 0)
+ *cbegin += ndims;
+
+ if (!static_cast<bool>(end)) {
Review comment:
you can use has_value for better readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
