szha commented on a change in pull request #11928: Generalized reshape_like
operator
URL: https://github.com/apache/incubator-mxnet/pull/11928#discussion_r207374276
##########
File path: src/operator/tensor/elemwise_unary_op.h
##########
@@ -476,6 +476,31 @@ void HardSigmoidBackward(const nnvm::NodeAttrs& attrs,
});
}
+struct ReshapeLikeParam : public dmlc::Parameter<ReshapeLikeParam> {
+ int lhs_begin, rhs_begin;
Review comment:
@taliesinb I think it doesn't hurt in this case and was suggesting that we
lean on the safer side. There might be cases where the default value filling on
the frontend fails, such as deserializing a graph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
