tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack
Transformation API
URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r207953711
##########
File path: python/mxnet/_ctypes/ndarray.py
##########
@@ -31,10 +31,10 @@
class NDArrayBase(object):
"""Base data structure for ndarray"""
- __slots__ = ["handle", "writable"]
+ __slots__ = ["handle", "writable", "dlpack_handle"]
Review comment:
do not put dlpack_handle inside it, instead directly return a pycapsule that
contains the handle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
