tqchen commented on a change in pull request #12047: [MXNET-779]Add DLPack
Transformation API
URL: https://github.com/apache/incubator-mxnet/pull/12047#discussion_r208659252
##########
File path: include/mxnet/tensor_blob.h
##########
@@ -104,6 +104,14 @@ class TBlob {
: dptr_(dptr), shape_(shape), type_flag_(type_flag) {
SetDLTensor(dev_mask, dev_id);
}
+ /*!
+ * \brief constructor that construct TBlob from DLTensor
+ * \param DLTensor Object
+ */
+ explicit TBlob(const DLTensor &dltensor) : dptr_(dltensor.data),
Review comment:
Specifically, TBlob only support compact tensors, need to check strides ==
null or the strides reflect a compact setting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
