asmushetzel commented on issue #12085: Accelerate the performance of topk for CPU side URL: https://github.com/apache/incubator-mxnet/pull/12085#issuecomment-411562290 Can you please elaborate a bit - what speedups do you see. I see that there are some numbers in #10205 but they all are for a single case k=3. We should make sure that other cases (k=N/2 etc) are also good. - what actually contributes to the speedup (it is not clear from the code what is it that makes it more efficient) It would be nice if you can also leave some comments in the code that indicates this in order to help other people understand why certain things are done the way they are now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
