asmushetzel commented on issue #12085: Accelerate the performance of topk for 
CPU side
URL: https://github.com/apache/incubator-mxnet/pull/12085#issuecomment-412074303
 
 
   @ciyongch Nice work! Reviewed it and looks good to me.  
   
   According to the code changes, the massive speedup for axis=3 and 
ret_type=indices/values/both is mainly attributed to the change concerning the 
modulo-computation. This means that a single modulo operation on the indices 
somehow attributed to 90% of the entire runtime, which is pretty insane. Is 
this a weak spot of the CPU-design? Or because mod-operations do not benefit 
from AVX (just speculating)? Can you guys from Intel comment on this a bit more?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to