ZhennanQin commented on a change in pull request #12104: [DO NOT REVIEW]
Subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/12104#discussion_r209132005
##########
File path: src/executor/graph_executor.cc
##########
@@ -1718,6 +1860,11 @@ Executor *Executor::SimpleBind(nnvm::Symbol symbol,
std::unordered_map<std::string, NDArray>*
shared_buffer,
Executor* shared_exec) {
auto exec = new exec::GraphExecutor();
+ if (!exec->subgraph_property().empty()) {
+ symbol = exec::PartitionGraph(symbol, exec->subgraph_property(),
arg_shape_map, arg_dtype_map,
Review comment:
Many subgraph pass can only be used on inference, eg. default_subgraph_op
doesn't have FGradient attribute and can't support backward computation. Maybe
default_subgraph_op will support backward in future, but some mkldnn fusion
pass is designed to be used in inference only. Shall we allow subgraph_property
to describe if it's inference only and apply it as it requires?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
