ZhennanQin commented on a change in pull request #12104: [DO NOT REVIEW] 
Subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/12104#discussion_r209150407
 
 

 ##########
 File path: src/executor/graph_executor.cc
 ##########
 @@ -1718,6 +1860,11 @@ Executor *Executor::SimpleBind(nnvm::Symbol symbol,
                                std::unordered_map<std::string, NDArray>* 
shared_buffer,
                                Executor* shared_exec) {
   auto exec = new exec::GraphExecutor();
+  if (!exec->subgraph_property().empty()) {
+    symbol = exec::PartitionGraph(symbol, exec->subgraph_property(), 
arg_shape_map, arg_dtype_map,
 
 Review comment:
   Yes, that's also my question. We indeed have some fusion passes only for 
inference, we need a way to disable it on training. If we can't describe this 
in subgraph property, then we need to find another way to indicate that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to