szha commented on a change in pull request #12064: Allow stop of arange to be
inferred from dims.
URL: https://github.com/apache/incubator-mxnet/pull/12064#discussion_r209504005
##########
File path: src/operator/tensor/init_op.h
##########
@@ -471,6 +473,11 @@ inline bool RangeShape(const nnvm::NodeAttrs& attrs,
<< "Range does not support step=0, received " << param.step;
CHECK(param.repeat > 0)
<< "Range only supports repeat > 0, received " << param.repeat;
+ if (param.start == param.stop.value()) {
Review comment:
though I understand that end=None is already taken, this condition still
feels a bit like a hack...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
