szha commented on a change in pull request #12064: Allow stop of arange to be
inferred from dims.
URL: https://github.com/apache/incubator-mxnet/pull/12064#discussion_r210963382
##########
File path: contrib/clojure-package/src/org/apache/clojure_mxnet/ndarray.clj
##########
@@ -83,10 +83,10 @@
"Returns evenly spaced values within a given interval.
Values are generated within the half-open interval [`start`, `stop`). In
other
words, the interval includes `start` but excludes `stop`."
- ([start stop {:keys [step repeat ctx dtype]
- :or {step (float 1) repeat (int 1) ctx
(mx-context/default-context) dtype base/MX_REAL_TYPE}
+ ([start stop {:keys [step repeat infer-range ctx dtype]
+ :or {step (float 1) repeat (int 1) infer-range false ctx
(mx-context/default-context) dtype base/MX_REAL_TYPE}
:as opts}]
- (NDArray/arange (float start) ($/option (float stop)) step repeat ctx
dtype))
+ (NDArray/arange (float start) ($/option (float stop)) step repeat
infer-range ctx dtype))
Review comment:
@gigasquid could you help review this part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
