lebeg commented on a change in pull request #12296: Separate minor refactoring
from #12276 in a prior PR
URL: https://github.com/apache/incubator-mxnet/pull/12296#discussion_r212223890
##########
File path: ci/build.py
##########
@@ -346,15 +429,21 @@ def use_cache():
tag = get_docker_tag(platform=platform,
registry=args.docker_registry)
if use_cache():
load_docker_cache(tag=tag,
docker_registry=args.docker_registry)
- build_docker(platform, docker_binary, args.docker_registry,
num_retries=num_docker_build_retires)
+ build_docker(platform, docker_binary, args.docker_registry,
num_retries=args.docker_build_retries,
+ use_cache=use_cache())
if args.build_only:
continue
- build_platform = "build_{}".format(platform)
- cmd = ["/work/mxnet/ci/docker/runtime_functions.sh",
build_platform]
+ git_cleanup()
Review comment:
This is good, but maybe we should issue a warning here with confirmation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
