lebeg commented on a change in pull request #12296: Separate minor refactoring
from #12276 in a prior PR
URL: https://github.com/apache/incubator-mxnet/pull/12296#discussion_r212244690
##########
File path: ci/build.py
##########
@@ -297,22 +377,24 @@ def script_name() -> str:
type=str)
args = parser.parse_args()
+
def use_cache():
- return args.cache or under_ci()
+ return not args.no_cache or under_ci()
command = list(chain(*args.command))
docker_binary = get_docker_binary(args.nvidiadocker)
shared_memory_size = args.shared_memory_size
num_docker_build_retires = args.docker_build_retries
if args.list:
- list_platforms()
+ print(list_platforms())
Review comment:
You used logger before, maybe use it here as well instead of print?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
