lebeg commented on a change in pull request #12331: [WIP] Moves f16c autodetection to its own cmake module URL: https://github.com/apache/incubator-mxnet/pull/12331#discussion_r212671656
########## File path: cmake/AutoDetectF16C.cmake ########## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +if(NOT DEFINED SUPPORT_F16C) + message(STATUS "Determining F16C support") + check_cxx_compiler_flag("-mf16c" COMPILER_SUPPORT_MF16C) + if(CMAKE_SYSTEM_NAME STREQUAL "Linux") + execute_process(COMMAND cat /proc/cpuinfo + COMMAND grep flags + COMMAND grep f16c + OUTPUT_VARIABLE CPU_SUPPORT_F16C) + elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin") + execute_process(COMMAND sysctl -a + COMMAND grep machdep.cpu.features + COMMAND grep F16C + OUTPUT_VARIABLE CPU_SUPPORT_F16C) + endif() + if(NOT CPU_SUPPORT_F16C) + message(STATUS "CPU does not support F16C instructions") + endif() + if(CPU_SUPPORT_F16C AND COMPILER_SUPPORT_MF16C) + message(STATUS "CPU does support F16C instructions") + set(SUPPORT_F16C TRUE) + endif() +endif() + +if(SUPPORT_F16C) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mf16c") Review comment: This could be done in the main CMakeLists.txt file, so this one would just determine if support can be enabled ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
