lebeg commented on a change in pull request #12331: [WIP] Moves f16c autodetection to its own cmake module URL: https://github.com/apache/incubator-mxnet/pull/12331#discussion_r213234383
########## File path: cmake/AutoDetectF16C.cmake ########## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Determines whether hardware and compiler support F16C +# instruction set +# +# The following are set after configuration is done: +# SUPPORT_F16C + +if(AUTO_DETECT_F16_CMAKE_INCLUDED) + return() +endif() + +set(AUTO_DETECT_F16_CMAKE_INCLUDED True) + +set(SUPPORT_F16C False) +if(MSVC) + message("F16C instruction set is not yet supported for MSVC") + return() +endif() +check_cxx_compiler_flag("-mf16c" COMPILER_SUPPORT_MF16C) Review comment: Almost forgot: to make the cmake file self contained you should include `include(CheckCXXCompilerFlag)` before. And check if it's still needed in the main cmake file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
