samskalicky commented on a change in pull request #12430: [MXNET-882] Support
for N-d arrays added to diag op.
URL: https://github.com/apache/incubator-mxnet/pull/12430#discussion_r215709714
##########
File path: src/operator/tensor/diag_op-inl.h
##########
@@ -104,26 +138,26 @@ inline bool DiagOpType(const nnvm::NodeAttrs& attrs,
return (*out_attrs)[0] != -1;
}
-template<int req>
+template<int ndim, int req, bool back>
struct diag {
template<typename DType>
MSHADOW_XINLINE static void Map(int i, DType* out, const DType* a,
- mshadow::Shape<2> ishape, int k) {
+ mshadow::Shape<ndim> oshape,
+ mshadow::Shape<ndim> ishape,
+ int stride, int offset,
+ int base) {
using namespace mxnet_op;
- int j = 0;
- if (k > 0) {
- j = ravel(mshadow::Shape2(i, i + k), ishape);
- } else if (k < 0) {
- j = ravel(mshadow::Shape2(i - k, i), ishape);
+ int idx = i / base;
+ int j = ravel(unravel(idx, oshape), ishape) + offset + stride * (i - idx *
base);
Review comment:
if we're looping over the indices in the output shape here (where "i" is the
index) what is "idx = i / base"? What is the base and why are we dividing by it?
I understand the ravel(unravel()) part, but what is the "+ offset + stride *
(i - idx * base)" part computing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
