samskalicky commented on a change in pull request #12430: [MXNET-882] Support
for N-d arrays added to diag op.
URL: https://github.com/apache/incubator-mxnet/pull/12430#discussion_r216087703
##########
File path: src/operator/tensor/diag_op-inl.h
##########
@@ -133,13 +167,94 @@ struct diag_gen {
auto j = unravel(i, oshape);
if (j[1] == (j[0] + k)) {
Review comment:
if the input shape is (3,3) then the output diagonal will be (3), will this
cause a problem with indexing j[1] since there wont be a 2nd dimension in the
oshape?
And why is oshape fixed at 2 dimensions? cant it be higher dimensions now
with your improvements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
