haojin2 commented on a change in pull request #12386: [MXNET-810] Add support
for more req patterns for bilinear sampler backward
URL: https://github.com/apache/incubator-mxnet/pull/12386#discussion_r216108611
##########
File path: src/operator/mxnet_op.h
##########
@@ -111,6 +111,33 @@ inline int get_num_threads<cpu>(const int N) {
}
+/*! \brief operator request type switch */
+#define MXNET_REQ_TYPE_SWITCH(req, ReqType, ...) \
Review comment:
because the one above will not generate any code when one of the input req
type is kNullOp:
https://github.com/apache/incubator-mxnet/pull/12386/files#diff-2e98465e383a92cb3c9a53e9f32658ceR92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
