haojin2 commented on a change in pull request #12386: [MXNET-810] Add support
for more req patterns for bilinear sampler backward
URL: https://github.com/apache/incubator-mxnet/pull/12386#discussion_r216497807
##########
File path: tests/python/gpu/test_operator_gpu.py
##########
@@ -1975,6 +1975,19 @@ def test_bilinear_sampler_versions():
assert_almost_equal(exe_list[ref_idx].grad_dict['data'].asnumpy(),
data_grad + data_initial_grad, rtol=1e-3, atol=1e-5)
assert_almost_equal(exe_list[ref_idx].grad_dict['grid'].asnumpy(),
grid_grad + grid_initial_grad, rtol=1e-3, atol=1e-5)
+ req_dict = {'data' : 'null', 'grid' : 'write'}
Review comment:
Added extra test case as per your review, should be good for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
