stu1130 commented on a change in pull request #12572: Make Gluon download
function to be atomic
URL: https://github.com/apache/incubator-mxnet/pull/12572#discussion_r218245647
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -195,6 +197,39 @@ def check_sha1(filename, sha1_hash):
return sha1.hexdigest() == sha1_hash
+if sys.platform != 'win32':
Review comment:
Thanks for raising the question. cygwin meets POSIX requirement and rename
is guaranteed to be atomic in POSIX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
