stu1130 commented on a change in pull request #12572: Make Gluon download
function to be atomic
URL: https://github.com/apache/incubator-mxnet/pull/12572#discussion_r219586150
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -195,6 +197,43 @@ def check_sha1(filename, sha1_hash):
return sha1.hexdigest() == sha1_hash
+if not sys.platform.startswith('win32'):
+ # refer to https://github.com/untitaker/python-atomicwrites
+ def _replace_atomic(src, dst):
+ """Implement atomic os.replace with linux and OSX. Internal use only"""
+ try:
+ os.rename(src, dst)
+ except OSError:
+ raise OSError(
+ 'Moving downloaded temp file - {}, to {} failed. Please retry
the download.'.format(src, dst))
+else:
+ from ctypes import windll, WinError
+
+ _MOVEFILE_REPLACE_EXISTING = 0x1
+ _MOVEFILE_WRITE_THROUGH = 0x8
+ _windows_default_flags = _MOVEFILE_WRITE_THROUGH
+
+ text_type = unicode if sys.version_info[0] == 2 else str # noqa
+
+ def _path_to_unicode(x):
+ """Handle text decoding. Internal use only"""
+ if not isinstance(x, text_type):
+ return x.decode(sys.getfilesystemencoding())
+ return x
+
+ def _handle_errors(rv):
+ """Handle WinError. Internal use only"""
+ if not rv:
+ raise WinError()
Review comment:
Good catch! will add more comments in docstring
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
